2021-06-12 16:06:57

by Anup Patel

Subject: [RFC PATCH v1 02/10] RISC-V: Use common print prefix in smp.c

We add "#define pr_fmt()" in smp.c to use "riscv:" as common
print prefix for all pr_xyz() statements in this file.

Signed-off-by: Anup Patel <[email protected]>
---
arch/riscv/kernel/smp.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
index 547dc508f7d1..eea0c9d11d9f 100644
--- a/arch/riscv/kernel/smp.c
+++ b/arch/riscv/kernel/smp.c
@@ -8,6 +8,7 @@
* Copyright (C) 2017 SiFive
*/

+#define pr_fmt(fmt) "riscv: " fmt
#include <linux/cpu.h>
#include <linux/clockchips.h>
#include <linux/interrupt.h>
@@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op)
if (ipi_ops && ipi_ops->ipi_inject)
ipi_ops->ipi_inject(mask);
else
- pr_warn("SMP: IPI inject method not available\n");
+ pr_warn("IPI inject method not available\n");
}

static void send_ipi_single(int cpu, enum ipi_message_type op)
@@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op)
if (ipi_ops && ipi_ops->ipi_inject)
ipi_ops->ipi_inject(cpumask_of(cpu));
else
- pr_warn("SMP: IPI inject method not available\n");
+ pr_warn("IPI inject method not available\n");
}

#ifdef CONFIG_IRQ_WORK
@@ -242,7 +243,7 @@ void smp_send_stop(void)
cpumask_clear_cpu(smp_processor_id(), &mask);

if (system_state <= SYSTEM_RUNNING)
- pr_crit("SMP: stopping secondary CPUs\n");
+ pr_crit("stopping secondary CPUs\n");
send_ipi_mask(&mask, IPI_CPU_STOP);
}

@@ -252,7 +253,7 @@ void smp_send_stop(void)
udelay(1);

if (num_online_cpus() > 1)
- pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
+ pr_warn("failed to stop secondary CPUs %*pbl\n",
cpumask_pr_args(cpu_online_mask));
}

--
2.25.1

2021-06-14 13:36:34

by Bin Meng

Subject: Re: [RFC PATCH v1 02/10] RISC-V: Use common print prefix in smp.c

On Sun, Jun 13, 2021 at 12:06 AM Anup Patel <[email protected]> wrote:
>
> We add "#define pr_fmt()" in smp.c to use "riscv:" as common
> print prefix for all pr_xyz() statements in this file.
>
> Signed-off-by: Anup Patel <[email protected]>
> ---
> arch/riscv/kernel/smp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>

Reviewed-by: Bin Meng <[email protected]>