2021-06-15 17:55:06

by George McCollister

[permalink] [raw]
Subject: [PATCH net-next] net: hsr: don't check sequence number if tag removal is offloaded

Don't check the sequence number when deciding when to update time_in in
the node table if tag removal is offloaded since the sequence number is
part of the tag. This fixes a problem where the times in the node table
wouldn't update when 0 appeared to be before or equal to seq_out when
tag removal was offloaded.

Signed-off-by: George McCollister <[email protected]>
---
net/hsr/hsr_framereg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
index bb1351c38397..e31949479305 100644
--- a/net/hsr/hsr_framereg.c
+++ b/net/hsr/hsr_framereg.c
@@ -397,7 +397,8 @@ void hsr_register_frame_in(struct hsr_node *node, struct hsr_port *port,
* ensures entries of restarted nodes gets pruned so that they can
* re-register and resume communications.
*/
- if (seq_nr_before(sequence_nr, node->seq_out[port->type]))
+ if (!(port->dev->features & NETIF_F_HW_HSR_TAG_RM) &&
+ seq_nr_before(sequence_nr, node->seq_out[port->type]))
return;

node->time_in[port->type] = jiffies;
--
2.11.0


2021-06-17 03:15:50

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] net: hsr: don't check sequence number if tag removal is offloaded

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 15 Jun 2021 12:50:37 -0500 you wrote:
> Don't check the sequence number when deciding when to update time_in in
> the node table if tag removal is offloaded since the sequence number is
> part of the tag. This fixes a problem where the times in the node table
> wouldn't update when 0 appeared to be before or equal to seq_out when
> tag removal was offloaded.
>
> Signed-off-by: George McCollister <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: hsr: don't check sequence number if tag removal is offloaded
https://git.kernel.org/netdev/net-next/c/c2ae34a7deaf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html