2021-06-16 03:51:39

by Yu Jiahua

Subject: [PATCH -next] drivers: ti: remove redundant error message in adpll.c

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Yu Jiahua <[email protected]>
---
drivers/clk/ti/adpll.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index bb2f2836dab2..b341cd990be7 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -896,11 +896,8 @@ static int ti_adpll_probe(struct platform_device *pdev)
d->pa = res->start;

d->iobase = devm_ioremap_resource(dev, res);
- if (IS_ERR(d->iobase)) {
- dev_err(dev, "could not get IO base: %li\n",
- PTR_ERR(d->iobase));
+ if (IS_ERR(d->iobase))
return PTR_ERR(d->iobase);
- }

err = ti_adpll_init_registers(d);
if (err)
--
2.17.1

2021-06-28 02:58:08

by Stephen Boyd

Subject: Re: [PATCH -next] drivers: ti: remove redundant error message in adpll.c

Quoting Yu Jiahua (2021-06-15 20:48:26)
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Yu Jiahua <[email protected]>
> ---

Applied to clk-next