2021-06-19 20:36:06

by Alex Bee

Subject: [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc

This might be a limitation of either the current panfrost driver
devfreq implementation or how the gpu is implemented in RK3399 SoC.
The gpu regulator must never get disabled or the registers get
(randomly?) inaccessable by the driver. (see all other RK3399 boards)

Fixes: ec7d731d81e7 ("arm64: dts: rockchip: Add node for gpu on rk3399-roc-pc")
Signed-off-by: Alex Bee <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index da3021dc0ff3..8b27ee4be755 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -494,6 +494,8 @@ vdd_gpu: regulator@41 {
regulator-min-microvolt = <712500>;
regulator-max-microvolt = <1500000>;
regulator-ramp-delay = <1000>;
+ regulator-always-on;
+ regulator-boot-on;
vin-supply = <&vcc3v3_sys>;

regulator-state-mem {
--
2.27.0

2021-06-19 22:05:34

by Heiko Stübner

Subject: Re: [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc

On Sat, 19 Jun 2021 14:14:46 +0200, Alex Bee wrote:
> This might be a limitation of either the current panfrost driver
> devfreq implementation or how the gpu is implemented in RK3399 SoC.
> The gpu regulator must never get disabled or the registers get
> (randomly?) inaccessable by the driver. (see all other RK3399 boards)

Applied, thanks!

[1/1] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc
commit: 06b2818678d9b35102c9816ffaf6893caf306ed0

Best regards,
--
Heiko Stuebner <[email protected]>