2021-06-22 12:00:26

by gushengxian

Subject: [PATCH] ata: rb532_cf: remove redundant codes

From: gushengxian <[email protected]>

The codes "dev_err(&pdev->dev, "no IRQ resource found\n");" is
redundant because platform_get_irq() already prints an error.

Signed-off-by: gushengxian <[email protected]>
---
drivers/ata/pata_rb532_cf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index 303f8c375b3a..2e110aefe59b 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no IRQ resource found\n");
+ if (irq < 0)
return irq;
- }
if (!irq)
return -EINVAL;

--
2.25.1

2021-06-25 00:50:18

by Jens Axboe

Subject: Re: [PATCH] ata: rb532_cf: remove redundant codes

On 6/22/21 5:55 AM, [email protected] wrote:
> From: gushengxian <[email protected]>
>
> The codes "dev_err(&pdev->dev, "no IRQ resource found\n");" is
> redundant because platform_get_irq() already prints an error.

Applied, thanks.

--
Jens Axboe