2021-06-11 07:34:28

by Robin Hsu

Subject: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments

From: Robin Hsu <[email protected]>

Since the IMMUTABLE flag for compression is now changed
to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
1. sload help page
2. inline comments

Signed-off-by: Robin Hsu <[email protected]>
---
fsck/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fsck/main.c b/fsck/main.c
index c07be1e..c0b871b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -149,7 +149,8 @@ void sload_usage()
MSG(0, " * -i or -x: use it many times for multiple extensions.\n");
MSG(0, " * -i and -x cannot be used together..\n");
MSG(0, " -m <num> min compressed blocks per cluster\n");
- MSG(0, " -r readonly (IMMUTABLE) for compressed files\n");
+ MSG(0, " -r read only (to release unused blocks) for compressed "
+ "files\n");
MSG(0, " ------------------------------------------------------\n");
MSG(0, " -d debug level [default:0]\n");
MSG(0, " -V print the version number and exit\n");
@@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
}
c.compress.min_blocks = val;
break;
- case 'r': /* compress file to set IMMUTABLE */
+ case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
c.compress.required = true;
c.compress.readonly = true;
break;
--
2.32.0.272.g935e593368-goog

2021-06-22 13:35:41

by Pavel Machek

Subject: Re: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments

Hi!

> Since the IMMUTABLE flag for compression is now changed
> to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> 1. sload help page
> 2. inline comments
>
> Signed-off-by: Robin Hsu <[email protected]>

> @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
> }
> c.compress.min_blocks = val;
> break;
> - case 'r': /* compress file to set IMMUTABLE */
> + case 'r': /* for setting F2FS_COMOPRESS_RELEASE */

Typo.

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2021-06-22 15:12:41

by Jaegeuk Kim

Subject: Re: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments

On 06/22, Pavel Machek wrote:
> Hi!
>
> > Since the IMMUTABLE flag for compression is now changed
> > to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> > 1. sload help page
> > 2. inline comments
> >
> > Signed-off-by: Robin Hsu <[email protected]>
>
> > @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
> > }
> > c.compress.min_blocks = val;
> > break;
> > - case 'r': /* compress file to set IMMUTABLE */
> > + case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
>
> Typo.

Ah, fixed. Thank you~

>
> Best regards,
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html