2021-06-23 00:54:07

by gushengxian

Subject: [PATCH] net: bridge: remove redundant return

From: gushengxian <[email protected]>

Return statements are not needed in Void function.

Signed-off-by: gushengxian <[email protected]>
---
net/bridge/br_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 8642e56059fb..b70075939721 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
{
u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;

- return br_info_notify(event, br, port, filter);
+ br_info_notify(event, br, port, filter);
}

/*
@@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = {
[IFLA_BRPORT_MODE] = { .type = NLA_U8 },
[IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
[IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
- [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 },
+ [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 },
[IFLA_BRPORT_LEARNING] = { .type = NLA_U8 },
[IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 },
[IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 },
--
2.25.1

2021-06-23 10:54:41

by Eric Dumazet

Subject: Re: [PATCH] net: bridge: remove redundant return

On 6/23/21 2:53 AM, [email protected] wrote:
> From: gushengxian <[email protected]>
>
> Return statements are not needed in Void function.

Maybe, but this just works.

I see your patch as a matter of taste.


>
> Signed-off-by: gushengxian <[email protected]>
> ---
> net/bridge/br_netlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 8642e56059fb..b70075939721 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
> {
> u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
>
> - return br_info_notify(event, br, port, filter);
> + br_info_notify(event, br, port, filter);
> }
>
> /*
> @@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = {
> [IFLA_BRPORT_MODE] = { .type = NLA_U8 },
> [IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
> - [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 },
> + [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 },

Useless noise.

> [IFLA_BRPORT_LEARNING] = { .type = NLA_U8 },
> [IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 },
>