2021-06-09 17:17:20

by Edward Wu

Subject: [PATCH net-dev] net: Exposing more skb fields in netif_receive_skb trace event

This exposing helps to analyze network behavior.

In performance tuning, we will check nr_frags to analyze
GRO aggregation behavior. By this commit, we can
enable netif_receive_skb trace event for dynamic debugging.

Signed-off-by: Edward Wu <[email protected]>
---
include/trace/events/net.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/trace/events/net.h b/include/trace/events/net.h
index 2399073c3afc..48aa7168b68f 100644
--- a/include/trace/events/net.h
+++ b/include/trace/events/net.h
@@ -147,13 +147,6 @@ DEFINE_EVENT(net_dev_template, net_dev_queue,
TP_ARGS(skb)
);

-DEFINE_EVENT(net_dev_template, netif_receive_skb,
-
- TP_PROTO(struct sk_buff *skb),
-
- TP_ARGS(skb)
-);
-
DEFINE_EVENT(net_dev_template, netif_rx,

TP_PROTO(struct sk_buff *skb),
@@ -239,6 +232,13 @@ DEFINE_EVENT(net_dev_rx_verbose_template, napi_gro_receive_entry,
TP_ARGS(skb)
);

+DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb,
+
+ TP_PROTO(const struct sk_buff *skb),
+
+ TP_ARGS(skb)
+);
+
DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb_entry,

TP_PROTO(const struct sk_buff *skb),
--
2.17.1

2021-06-23 11:27:38

by Edward Wu

Subject: [PATCH net-next resend] net: Exposing more skb fields in netif_receive_skb trace event

This exposing helps to analyze network behavior.

In performance tuning, we will check nr_frags to analyze
GRO aggregation behavior. By this commit, we can
enable netif_receive_skb trace event for dynamic debugging.

Signed-off-by: Edward Wu <[email protected]>
---
include/trace/events/net.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/trace/events/net.h b/include/trace/events/net.h
index 2399073c3afc..48aa7168b68f 100644
--- a/include/trace/events/net.h
+++ b/include/trace/events/net.h
@@ -147,13 +147,6 @@ DEFINE_EVENT(net_dev_template, net_dev_queue,
TP_ARGS(skb)
);

-DEFINE_EVENT(net_dev_template, netif_receive_skb,
-
- TP_PROTO(struct sk_buff *skb),
-
- TP_ARGS(skb)
-);
-
DEFINE_EVENT(net_dev_template, netif_rx,

TP_PROTO(struct sk_buff *skb),
@@ -239,6 +232,13 @@ DEFINE_EVENT(net_dev_rx_verbose_template, napi_gro_receive_entry,
TP_ARGS(skb)
);

+DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb,
+
+ TP_PROTO(const struct sk_buff *skb),
+
+ TP_ARGS(skb)
+);
+
DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb_entry,

TP_PROTO(const struct sk_buff *skb),
--
2.17.1