2021-06-23 11:33:36

by Sean Nyekjaer

Subject: [PATCH] iio: accel: fxls8962af: fix potential use of uninitialized symbol

Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
---
drivers/iio/accel/fxls8962af-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 078d87865fde..0019f1ea7df2 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
return ret;
}

- return ret;
+ return 0;
}

static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
--
2.31.0

2021-07-18 14:36:07

by Jonathan Cameron

Subject: Re: [PATCH] iio: accel: fxls8962af: fix potential use of uninitialized symbol

On Wed, 23 Jun 2021 13:31:15 +0200
Sean Nyekjaer <[email protected]> wrote:

> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Sean Nyekjaer <[email protected]>
> Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
Oops. Seems I applied this but didn't reply here to say I'd done so.

Thanks,

Jonathan

> ---
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..0019f1ea7df2 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
> return ret;
> }
>
> - return ret;
> + return 0;
> }
>
> static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,