2021-06-23 16:15:26

by Stefano Garzarella

[permalink] [raw]
Subject: Re: [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper

On Wed, Jun 23, 2021 at 11:16:22AM -0400, Xianting Tian wrote:
>virtio_find_vqs_ctx() is defined but never be called currently,
>it is the right place to use it.
>
>Signed-off-by: Xianting Tian <[email protected]>
>---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <[email protected]>

>
>diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>index 78a01c7..9061c55 100644
>--- a/drivers/net/virtio_net.c
>+++ b/drivers/net/virtio_net.c
>@@ -2830,8 +2830,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
> ctx[rxq2vq(i)] = true;
> }
>
>- ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks,
>- names, ctx, NULL);
>+ ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks,
>+ names, ctx, NULL);
> if (ret)
> goto err_find;
>
>--
>1.8.3.1
>