2021-06-25 04:51:34

by Judy Hsiao

Subject: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A

Use max98360a dts node to correctly describe the hardware.

Signed-off-by: Judy Hsiao <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 77ae7561d436..38f1fababc33 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -247,8 +247,8 @@ pen_insert: pen-insert {
};
};

- max98357a: audio-codec-0 {
- compatible = "maxim,max98357a";
+ max98360a: audio-codec-0 {
+ compatible = "maxim,max98360a";
pinctrl-names = "default";
pinctrl-0 = <&amp_en>;
sdmode-gpios = <&tlmm 23 GPIO_ACTIVE_HIGH>;
@@ -311,7 +311,7 @@ cpu {
};

sound_multimedia1_codec: codec {
- sound-dai = <&max98357a>;
+ sound-dai = <&max98360a>;
};
};
};
--
2.32.0.93.g670b81a890-goog

2021-06-25 15:29:12

by Matthias Kaehlcke

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A

On Fri, Jun 25, 2021 at 12:50:10PM +0800, Judy Hsiao wrote:
> Use max98360a dts node to correctly describe the hardware.
>
> Signed-off-by: Judy Hsiao <[email protected]>

Confirmed that this matches the schematics. Apparently 'max98357a' was
used initially because 'max98360a' wasn't supported yet in the kernel
that was used for development and ships on trogdor devices (v5.4).

Reviewed-by: Matthias Kaehlcke <[email protected]>

2021-07-21 21:02:45

by Doug Anderson

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A

Hi Bjorn,

On Thu, Jun 24, 2021 at 9:50 PM Judy Hsiao <[email protected]> wrote:
>
> Use max98360a dts node to correctly describe the hardware.
>
> Signed-off-by: Judy Hsiao <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

I noticed that you landed several dts changes recently (thanks!) but I
didn't see this one. Was there a problem with it, or did it just slip
through the cracks?

Thanks!

-Doug

2021-07-21 21:04:50

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: trogdor: Update audio codec to Max98360A

On Wed 21 Jul 10:27 CDT 2021, Doug Anderson wrote:

> Hi Bjorn,
>
> On Thu, Jun 24, 2021 at 9:50 PM Judy Hsiao <[email protected]> wrote:
> >
> > Use max98360a dts node to correctly describe the hardware.
> >
> > Signed-off-by: Judy Hsiao <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> I noticed that you landed several dts changes recently (thanks!) but I
> didn't see this one. Was there a problem with it, or did it just slip
> through the cracks?
>

No problem, it just sat there nicely waiting in the backlog. It's now
applied and pushed out.

Thanks,
Bjorn