2021-06-25 07:16:28

by Drew Fustini

Subject: [PATCH v2] dt-bindings: riscv: add starfive jh7100 bindings

Add DT binding documentation for the StarFive JH7100 Soc [1] and the
BeagleV Starlight JH7100 board [2].

[1] https://github.com/starfive-tech/beaglev_doc
[2] https://github.com/beagleboard/beaglev-starlight

Signed-off-by: Drew Fustini <[email protected]>
---
v2 changes:
- removed "items:" entry that only had "const: starfive,jh7100"
- correct typo in Description:

Results of running checks:

$ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
DTEX Documentation/devicetree/bindings/riscv/starfive.example.dts
DTC Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
CHECK Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml

$ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \
DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
DTC arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
CHECK arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml

The dts file is from vendor repo and is being cleaned up right now in
preperation for submitting to the mailing list:
https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive

.../devicetree/bindings/riscv/starfive.yaml | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml

diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
new file mode 100644
index 000000000000..68954d0a7108
--- /dev/null
+++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/riscv/starfive.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive SoC-based boards
+
+maintainers:
+ - Michael Zhu <[email protected]>
+ - Drew Fustini <[email protected]>
+
+description:
+ StarFive SoC-based boards
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - items:
+ - const: beagle,beaglev-starlight-jh7100
+ - const: starfive,jh7100
+
+additionalProperties: true
+
+...
--
2.27.0

2021-07-06 23:18:14

by Palmer Dabbelt

Subject: Re: [PATCH v2] dt-bindings: riscv: add starfive jh7100 bindings

On Fri, 25 Jun 2021 00:12:42 PDT (-0700), [email protected] wrote:
> Add DT binding documentation for the StarFive JH7100 Soc [1] and the
> BeagleV Starlight JH7100 board [2].
>
> [1] https://github.com/starfive-tech/beaglev_doc
> [2] https://github.com/beagleboard/beaglev-starlight
>
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> v2 changes:
> - removed "items:" entry that only had "const: starfive,jh7100"
> - correct typo in Description:
>
> Results of running checks:
>
> $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> DTEX Documentation/devicetree/bindings/riscv/starfive.example.dts
> DTC Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
> CHECK Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
>
> $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> DTC arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
> CHECK arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
>
> The dts file is from vendor repo and is being cleaned up right now in
> preperation for submitting to the mailing list:
> https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive
>
> .../devicetree/bindings/riscv/starfive.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> new file mode 100644
> index 000000000000..68954d0a7108
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/starfive.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive SoC-based boards
> +
> +maintainers:
> + - Michael Zhu <[email protected]>
> + - Drew Fustini <[email protected]>
> +
> +description:
> + StarFive SoC-based boards
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - const: beagle,beaglev-starlight-jh7100
> + - const: starfive,jh7100

The SiFive boards have

oneOf:
- items:
- enum:
- sifive,hifive-unleashed-a00
- const: sifive,fu540-c000
- const: sifive,fu540

IIUC there's no practical difference between a single-option enum and
the const, but it does bring up the board version number. Is there any
revision number on the beaglev boards?

> +
> +additionalProperties: true
> +
> +...

Acked-by: Palmer Dabbelt <[email protected]>

as I'm assuming this is targeted towards the DT tree. Thanks!