2021-06-26 10:17:31

by Jinchao Wang

Subject: [PATCH] auxdisplay: Replace symbolic permissions with octal permissions

Resolve following checkpatch issue,
Replace symbolic permissions with octal permissions

Signed-off-by: Jinchao Wang <[email protected]>
---
drivers/auxdisplay/cfag12864b.c | 2 +-
drivers/auxdisplay/ks0108.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c
index fd430e6866a1..6526aa51fb1d 100644
--- a/drivers/auxdisplay/cfag12864b.c
+++ b/drivers/auxdisplay/cfag12864b.c
@@ -33,7 +33,7 @@
*/

static unsigned int cfag12864b_rate = CONFIG_CFAG12864B_RATE;
-module_param(cfag12864b_rate, uint, S_IRUGO);
+module_param(cfag12864b_rate, uint, 0444);
MODULE_PARM_DESC(cfag12864b_rate,
"Refresh rate (hertz)");

diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index 03c95ad4216c..313c5305416a 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -28,11 +28,11 @@
*/

static unsigned int ks0108_port = CONFIG_KS0108_PORT;
-module_param(ks0108_port, uint, S_IRUGO);
+module_param(ks0108_port, uint, 0444);
MODULE_PARM_DESC(ks0108_port, "Parallel port where the LCD is connected");

static unsigned int ks0108_delay = CONFIG_KS0108_DELAY;
-module_param(ks0108_delay, uint, S_IRUGO);
+module_param(ks0108_delay, uint, 0444);
MODULE_PARM_DESC(ks0108_delay, "Delay between each control writing (microseconds)");

/*
--
2.31.1

2021-07-15 23:55:01

by Miguel Ojeda

Subject: Re: [PATCH] auxdisplay: Replace symbolic permissions with octal permissions

On Sat, Jun 26, 2021 at 12:16 PM Jinchao Wang <[email protected]> wrote:
>
> Resolve following checkpatch issue,
> Replace symbolic permissions with octal permissions
>
> Signed-off-by: Jinchao Wang <[email protected]>

Thanks -- queued.

Cheers,
Miguel