2021-06-28 12:39:51

by Jiabing Wan

Subject: [PATCH] lkdtm: remove duplicated include of init.h

Fix following checkincludes.pl warning:
./drivers/misc/lkdtm/core.c
26 #include <linux/init.h>
29 #include <linux/init.h>

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/misc/lkdtm/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/misc/lkdtm/core.c b/drivers/misc/lkdtm/core.c
index 9dda87c6b54a..c9a0ad6d5d72 100644
--- a/drivers/misc/lkdtm/core.c
+++ b/drivers/misc/lkdtm/core.c
@@ -26,7 +26,6 @@
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/debugfs.h>
-#include <linux/init.h>

#define DEFAULT_COUNT 10

--
2.20.1

2021-06-29 00:31:49

by Kees Cook

Subject: Re: [PATCH] lkdtm: remove duplicated include of init.h

On Mon, Jun 28, 2021 at 08:35:12PM +0800, Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./drivers/misc/lkdtm/core.c
> 26 #include <linux/init.h>
> 29 #include <linux/init.h>
>
> Signed-off-by: Wan Jiabing <[email protected]>

Whoops! Thank you. :)

Acked-by: Kees Cook <[email protected]>

-Kees

> ---
> drivers/misc/lkdtm/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm/core.c b/drivers/misc/lkdtm/core.c
> index 9dda87c6b54a..c9a0ad6d5d72 100644
> --- a/drivers/misc/lkdtm/core.c
> +++ b/drivers/misc/lkdtm/core.c
> @@ -26,7 +26,6 @@
> #include <linux/init.h>
> #include <linux/slab.h>
> #include <linux/debugfs.h>
> -#include <linux/init.h>
>
> #define DEFAULT_COUNT 10
>
> --
> 2.20.1
>

--
Kees Cook