2021-06-27 22:38:08

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] x86/SGX: drop spurious kernel-doc notation

Drop mistaken kernel-doc notation where plain C comments
should be used instead.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Jarkko Sakkinen <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: [email protected]
---
arch/x86/kernel/cpu/sgx/encl.h | 2 +-
arch/x86/kernel/cpu/sgx/encls.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encl.h
+++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encl.h
@@ -1,5 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/**
+/*
* Copyright(c) 2016-20 Intel Corporation.
*
* Contains the software defined data structures for enclaves.
--- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encls.h
+++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encls.h
@@ -11,7 +11,7 @@
#include <asm/traps.h>
#include "sgx.h"

-/**
+/*
* ENCLS_FAULT_FLAG - flag signifying an ENCLS return code is a trapnr
*
* ENCLS has its own (positive value) error codes and also generates


2021-06-29 21:23:47

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH] x86/SGX: drop spurious kernel-doc notation

On Sun, Jun 27, 2021 at 03:36:39PM -0700, Randy Dunlap wrote:
> Drop mistaken kernel-doc notation where plain C comments
> should be used instead.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Jarkko Sakkinen <[email protected]>
> Cc: Dave Hansen <[email protected]>
> Cc: [email protected]

"x86/SGX" -> "x86/sgx"

Anyway,

Reviewed-by: Jarkko Sakkinen <[email protected]>

> ---
> arch/x86/kernel/cpu/sgx/encl.h | 2 +-
> arch/x86/kernel/cpu/sgx/encls.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encl.h
> +++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encl.h
> @@ -1,5 +1,5 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -/**
> +/*
> * Copyright(c) 2016-20 Intel Corporation.
> *
> * Contains the software defined data structures for enclaves.
> --- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encls.h
> +++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encls.h
> @@ -11,7 +11,7 @@
> #include <asm/traps.h>
> #include "sgx.h"
>
> -/**
> +/*
> * ENCLS_FAULT_FLAG - flag signifying an ENCLS return code is a trapnr
> *
> * ENCLS has its own (positive value) error codes and also generates
>

/Jarkko