2021-06-30 20:38:42

by Abd-Alrhman Masalkhi

Subject: [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes]

In the first patch I have not defined the print_disk_stats function
static so it triggered an [-Wmissing-prototypes] warning, fixing it
by defineing the function static.

Signed-off-by: Abd-Alrhman Masalkhi <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
block/genhd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index 5d393b2bc62c..803c3448f09a 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1107,8 +1107,8 @@ const struct device_type disk_type = {

#ifdef CONFIG_PROC_FS

-void print_disk_stats(struct seq_file *seqf,
- unsigned int inflight, struct disk_stats *stat)
+static void print_disk_stats(struct seq_file *seqf,
+ unsigned int inflight, struct disk_stats *stat)
{
seq_printf(seqf, "%lu %lu %lu %u "
"%lu %lu %lu %u "
--
2.29.0.rc1.dirty

2021-06-30 20:41:25

by Jens Axboe

Subject: Re: [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes]

On 6/30/21 2:37 PM, Abd-Alrhman Masalkhi wrote:
> In the first patch I have not defined the print_disk_stats function
> static so it triggered an [-Wmissing-prototypes] warning, fixing it
> by defineing the function static.

Just send a v2 of the patch, there's no point in applying a known
broken patch to then just do a followup of it.

--
Jens Axboe