2021-07-07 07:53:32

by Yue Haibing

Subject: [PATCH net] stmmac: dwmac-loongson: Fix unsigned comparison to zero

plat->phy_interface is unsigned integer, so the condition
can't be less than zero and the warning will never printed.

Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index e108b0d2bd28..4c9a37dd0d3f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -49,9 +49,9 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
{
struct plat_stmmacenet_data *plat;
struct stmmac_resources res;
- bool mdio = false;
- int ret, i;
struct device_node *np;
+ int ret, i, phy_mode;
+ bool mdio = false;

np = dev_of_node(&pdev->dev);

@@ -108,10 +108,11 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
if (plat->bus_id < 0)
plat->bus_id = pci_dev_id(pdev);

- plat->phy_interface = device_get_phy_mode(&pdev->dev);
- if (plat->phy_interface < 0)
+ phy_mode = device_get_phy_mode(&pdev->dev);
+ if (phy_mode < 0)
dev_err(&pdev->dev, "phy_mode not found\n");

+ plat->phy_interface = phy_mode;
plat->interface = PHY_INTERFACE_MODE_GMII;

pci_set_master(pdev);
--
2.20.1

2021-07-07 21:48:14

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] stmmac: dwmac-loongson: Fix unsigned comparison to zero

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 7 Jul 2021 15:50:57 +0800 you wrote:
> plat->phy_interface is unsigned integer, so the condition
> can't be less than zero and the warning will never printed.
>
> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)

Here is the summary with links:
- [net] stmmac: dwmac-loongson: Fix unsigned comparison to zero
https://git.kernel.org/netdev/net/c/0d472c69c6a5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html