2021-07-07 17:18:26

by Yu Zhang

Subject: [PATCH] KVM: VMX: Remove vmx_msr_index from vmx.h

vmx_msr_index was used to record the list of MSRs which can be lazily
restored when kvm returns to userspace. It is now reimplemented as
kvm_uret_msrs_list, a common x86 list which is only used inside x86.c.
So just remove the obsolete declaration in vmx.h.

Signed-off-by: Yu Zhang <[email protected]>
---
arch/x86/kvm/vmx/vmx.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
index 3979a947933a..db88ed4f2121 100644
--- a/arch/x86/kvm/vmx/vmx.h
+++ b/arch/x86/kvm/vmx/vmx.h
@@ -14,8 +14,6 @@
#include "vmx_ops.h"
#include "cpuid.h"

-extern const u32 vmx_msr_index[];
-
#define MSR_TYPE_R 1
#define MSR_TYPE_W 2
#define MSR_TYPE_RW 3
--
2.17.1

2021-07-08 17:05:01

by Paolo Bonzini

Subject: Re: [PATCH] KVM: VMX: Remove vmx_msr_index from vmx.h

On 08/07/21 01:57, Yu Zhang wrote:
> vmx_msr_index was used to record the list of MSRs which can be lazily
> restored when kvm returns to userspace. It is now reimplemented as
> kvm_uret_msrs_list, a common x86 list which is only used inside x86.c.
> So just remove the obsolete declaration in vmx.h.
>
> Signed-off-by: Yu Zhang <[email protected]>
> ---
> arch/x86/kvm/vmx/vmx.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> index 3979a947933a..db88ed4f2121 100644
> --- a/arch/x86/kvm/vmx/vmx.h
> +++ b/arch/x86/kvm/vmx/vmx.h
> @@ -14,8 +14,6 @@
> #include "vmx_ops.h"
> #include "cpuid.h"
>
> -extern const u32 vmx_msr_index[];
> -
> #define MSR_TYPE_R 1
> #define MSR_TYPE_W 2
> #define MSR_TYPE_RW 3
>

Queued, thanks.

Paolo