2021-07-08 09:52:08

by Gatis Peisenieks

Subject: [PATCH net] atl1c: fix Mikrotik 10/25G NIC detection

Since Mikrotik 10/25G NIC MDIO op emulation is not 100% reliable,
on rare occasions it can happen that some physical functions of
the NIC do not get initialized due to timeouted early MDIO op.

This changes the atl1c probe on Mikrotik 10/25G NIC not to
depend on MDIO op emulation.

Signed-off-by: Gatis Peisenieks <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
index 7dff20350865..f19370c33444 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
@@ -594,6 +594,11 @@ int atl1c_phy_init(struct atl1c_hw *hw)
int ret_val;
u16 mii_bmcr_data = BMCR_RESET;

+ if (hw->nic_type == athr_mt) {
+ hw->phy_configured = true;
+ return 0;
+ }
+
if ((atl1c_read_phy_reg(hw, MII_PHYSID1, &hw->phy_id1) != 0) ||
(atl1c_read_phy_reg(hw, MII_PHYSID2, &hw->phy_id2) != 0)) {
dev_err(&pdev->dev, "Error get phy ID\n");
--
2.31.1

2021-07-08 20:41:47

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] atl1c: fix Mikrotik 10/25G NIC detection

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 8 Jul 2021 12:49:04 +0300 you wrote:
> Since Mikrotik 10/25G NIC MDIO op emulation is not 100% reliable,
> on rare occasions it can happen that some physical functions of
> the NIC do not get initialized due to timeouted early MDIO op.
>
> This changes the atl1c probe on Mikrotik 10/25G NIC not to
> depend on MDIO op emulation.
>
> [...]

Here is the summary with links:
- [net] atl1c: fix Mikrotik 10/25G NIC detection
https://git.kernel.org/netdev/net/c/b9d233ea21f1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html