2021-07-13 14:08:25

by Srinivas Kandagatla

[permalink] [raw]
Subject: [PATCH] ASoC: codecs: wcd938x: make sdw dependency explicit in Kconfig

currenlty wcd938x has only soundwire interface and depends on
symbols from wcd938x soundwire module, so make this dependency
explicit in Kconfig

Without this one of the randconfig endup setting
CONFIG_SND_SOC_WCD938X=y
CONFIG_SND_SOC_WCD938X_SDW=m
resulting in some undefined reference to wcd938x_sdw* symbols.

Reported-by: kernel test robot <[email protected]>
Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig")
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 2d80836ef220..f47d46eb76bc 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1557,6 +1557,7 @@ config SND_SOC_WCD934X
Qualcomm SoCs like SDM845.

config SND_SOC_WCD938X
+ depends on SND_SOC_WCD938X_SDW
tristate

config SND_SOC_WCD938X_SDW
--
2.21.0


2021-07-14 15:57:19

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: codecs: wcd938x: make sdw dependency explicit in Kconfig

On Tue, 13 Jul 2021 15:04:17 +0100, Srinivas Kandagatla wrote:
> currenlty wcd938x has only soundwire interface and depends on
> symbols from wcd938x soundwire module, so make this dependency
> explicit in Kconfig
>
> Without this one of the randconfig endup setting
> CONFIG_SND_SOC_WCD938X=y
> CONFIG_SND_SOC_WCD938X_SDW=m
> resulting in some undefined reference to wcd938x_sdw* symbols.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: wcd938x: make sdw dependency explicit in Kconfig
commit: 9431f8df233f808baa5fcc62b520cc6503fdf022

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark