2021-06-29 12:52:08

by William Breathitt Gray

[permalink] [raw]

Subject: Re: [PATCH] counter: intel-qep: Remove linux/bitops.h include

---

On Tue, Jun 29, 2021 at 02:16:57PM +0300, Jarkko Nikula wrote:
> 0-DAY CI Kernel Test Service reported following iwyu warning:
>
> drivers/counter/intel-qep.c:11:1: iwyu: warning: superfluous #include <linux/bitops.h>
>
> Remove that include since we don't seem to use anything from it.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Jarkko Nikula <[email protected]>

Acked-by: William Breathitt Gray <[email protected]>

> ---
> drivers/counter/intel-qep.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/counter/intel-qep.c b/drivers/counter/intel-qep.c
> index 8d7ae28fbd67..1a9512e28519 100644
> --- a/drivers/counter/intel-qep.c
> +++ b/drivers/counter/intel-qep.c
> @@ -8,7 +8,6 @@
> * Author: Jarkko Nikula <[email protected]>
> * Author: Raymond Tan <[email protected]>
> */
> -#include <linux/bitops.h>
> #include <linux/counter.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> --
> 2.30.2
>

---

Attachments:

(No filename) (1.01 kB)
signature.asc (849.00 B)
Download all attachments

2021-07-13 18:07:01

by Jonathan Cameron

[permalink] [raw]

Subject: Re: [PATCH] counter: intel-qep: Remove linux/bitops.h include

---

On Tue, 29 Jun 2021 21:05:39 +0900
William Breathitt Gray <[email protected]> wrote:

> On Tue, Jun 29, 2021 at 02:16:57PM +0300, Jarkko Nikula wrote:
> > 0-DAY CI Kernel Test Service reported following iwyu warning:
> >
> > drivers/counter/intel-qep.c:11:1: iwyu: warning: superfluous #include <linux/bitops.h>
> >
> > Remove that include since we don't seem to use anything from it.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Jarkko Nikula <[email protected]>
>
> Acked-by: William Breathitt Gray <[email protected]>
Applied,

Thanks,

Jonathan

>
> > ---
> > drivers/counter/intel-qep.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/counter/intel-qep.c b/drivers/counter/intel-qep.c
> > index 8d7ae28fbd67..1a9512e28519 100644
> > --- a/drivers/counter/intel-qep.c
> > +++ b/drivers/counter/intel-qep.c
> > @@ -8,7 +8,6 @@
> > * Author: Jarkko Nikula <[email protected]>
> > * Author: Raymond Tan <[email protected]>
> > */
> > -#include <linux/bitops.h>
> > #include <linux/counter.h>
> > #include <linux/kernel.h>
> > #include <linux/module.h>
> > --
> > 2.30.2
> >