2021-07-14 20:37:42

by Sonia Sharma

Subject: [PATCH] hyperv: Remove unused inline functions in hyperv.h

There are some unused inline functions in hyperv.h file.
Removing those unused functions.

Signed-off-by: Sonia Sharma <[email protected]>
---
include/linux/hyperv.h | 22 ----------------------
1 file changed, 22 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index b3e2436..1f1f0f8 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -481,12 +481,6 @@ struct vmbus_channel_rescind_offer {
u32 child_relid;
} __packed;

-static inline u32
-hv_ringbuffer_pending_size(const struct hv_ring_buffer_info *rbi)
-{
- return rbi->ring_buffer->pending_send_sz;
-}
-
/*
* Request Offer -- no parameters, SynIC message contains the partition ID
* Set Snoop -- no parameters, SynIC message contains the partition ID
@@ -913,12 +907,6 @@ static inline bool is_hvsock_channel(const struct vmbus_channel *c)
VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER);
}

-static inline void set_channel_affinity_state(struct vmbus_channel *c,
- enum hv_numa_policy policy)
-{
- c->affinity_policy = policy;
-}
-
static inline void set_channel_read_mode(struct vmbus_channel *c,
enum hv_callback_mode mode)
{
@@ -941,16 +929,6 @@ static inline void set_channel_pending_send_size(struct vmbus_channel *c,
c->outbound.ring_buffer->pending_send_sz = size;
}

-static inline void set_low_latency_mode(struct vmbus_channel *c)
-{
- c->low_latency = true;
-}
-
-static inline void clear_low_latency_mode(struct vmbus_channel *c)
-{
- c->low_latency = false;
-}
-
void vmbus_onmessage(void *context);

int vmbus_request_offers(void);
--
1.8.3.1

2021-07-15 14:09:48

by Wei Liu

Subject: Re: [PATCH] hyperv: Remove unused inline functions in hyperv.h

Hi Sonia

On Wed, Jul 14, 2021 at 01:20:34PM -0700, Sonia Sharma wrote:
[...]
> -static inline void set_channel_affinity_state(struct vmbus_channel *c,
> - enum hv_numa_policy policy)
> -{
> - c->affinity_policy = policy;
> -}
> -

This function was removed in 8ef4c4abbbc which was committed more than a
year ago.

The other three indeed have no users in tree.

For uptream development please base your changes on the hyperv-next
branch (new features, improvements) or hyperv-fixes branch (bug fixes).

See https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/ .

Wei.