2021-07-16 09:20:53

by xiaoqiang zhao

Subject: [PATCH] cgroup: remove cgroup_mount from comments

From: zhaoxiaoqiang11 <[email protected]>

Git rid of the inappropriate comment

Since cgroup is fully switched to fs_context, function cgroup_mount
is removed and it's confused to mention in comments of cgroup_kill_sb.
Just wipe it out.

Signed-off-by: zhaoxiaoqiang11 <[email protected]>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 3a0161c21b6b..d0725c1a8db5 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2169,7 +2169,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.27.0

2021-07-16 16:19:26

by Tejun Heo

Subject: Re: [PATCH] cgroup: remove cgroup_mount from comments

On Fri, Jul 16, 2021 at 05:18:53PM +0800, [email protected] wrote:
> From: zhaoxiaoqiang11 <[email protected]>
>
> Git rid of the inappropriate comment
>
> Since cgroup is fully switched to fs_context, function cgroup_mount
> is removed and it's confused to mention in comments of cgroup_kill_sb.
> Just wipe it out.
>
> Signed-off-by: zhaoxiaoqiang11 <[email protected]>

Applied to cgroup/for-5.15 w/ some description tweaks.

Thanks.

--
tejun