Hi all,
In commit
6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
Fixes tag
Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
Hi Stephen,
On Mon, Jul 19, 2021 at 08:19:26AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
>
> Fixes tag
>
> Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
> --
> Cheers,
> Stephen Rothwell
D'oh. Do people fix these things generally with a rebase?
- Moritz
Hi Moritz,
On Sun, 18 Jul 2021 15:48:15 -0700 Moritz Fischer <[email protected]> wrote:
>
> On Mon, Jul 19, 2021 at 08:19:26AM +1000, Stephen Rothwell wrote:
> >
> > In commit
> >
> > 6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
> >
> > Fixes tag
> >
> > Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing parentheses
> > - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
>
> D'oh. Do people fix these things generally with a rebase?
It varies among maintainers, but a rebase is the only way to fix it (if
that is what you want to do).
You could just take it as a lesson for the future.
--
Cheers,
Stephen Rothwell