2021-07-20 06:40:44

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the overlayfs tree

---

Hi all,

After merging the overlayfs tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/api-summary:95: fs/stat.c:67: WARNING: Unknown target name: "statx_attr".

Introduced by commit

d1e717e0032c ("fs: add generic helper for filling statx attribute flags")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-07-21 18:29:17

by Miklos Szeredi

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the overlayfs tree

---

On Tue, 20 Jul 2021 at 08:38, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the overlayfs tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/api-summary:95: fs/stat.c:67: WARNING: Unknown target name: "statx_attr".
>
> Introduced by commit
>
> d1e717e0032c ("fs: add generic helper for filling statx attribute flags")

Thanks, fix folded and force pushed.

Miklos

2017-11-09 03:59:10

by Chandan Rajendra

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the overlayfs tree

---

On Thursday, November 9, 2017 4:03:06 AM IST Stephen Rothwell wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/overlayfs/super.c: In function 'ovl_fill_super':
> fs/overlayfs/super.c:1070:25: warning: 'numlower' may be used uninitialized in this function [-Wmaybe-uninitialized]
> unsigned int stacklen, numlower, i;
> ^
> fs/overlayfs/super.c:1069:15: warning: 'stack' may be used uninitialized in this function [-Wmaybe-uninitialized]
> struct path *stack;
> ^
>
>

The following trivial patch resolves the warnings,

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index fd11c05..602e686 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1066,8 +1066,8 @@ static struct ovl_entry *ovl_get_lowerstack(struct super_block *sb,
{
int err;
char *lowertmp, *lower;
- struct path *stack;
- unsigned int stacklen, numlower, i;
+ struct path *stack = NULL;
+ unsigned int stacklen, numlower = 0, i;
bool remote = false;
struct ovl_entry *oe;

--
chandan


From 1583539002149278154@xxx Wed Nov 08 22:34:35 +0000 2017
X-GM-THRID: 1583539002149278154
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread