2021-07-21 09:13:17

by Wanghui (John)

Subject: [PATCH -next] sched: remove redundant on_rq status change

activate_task/deactivate_task will change on_rq status,
no need to do it again.

Signed-off-by: Wang Hui <[email protected]>
---
kernel/sched/core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 014ce8b385c7..a0c35da186d0 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5679,11 +5679,9 @@ static bool try_steal_cookie(int this, int that)
if (p->core_occupation > dst->idle->core_occupation)
goto next;

- p->on_rq = TASK_ON_RQ_MIGRATING;
deactivate_task(src, p, 0);
set_task_cpu(p, this);
activate_task(dst, p, 0);
- p->on_rq = TASK_ON_RQ_QUEUED;

resched_curr(dst);

--
2.29.0

2021-08-05 09:39:30

by tip-bot2 for Alexey Makhalov

Subject: [tip: sched/core] sched: remove redundant on_rq status change

The following commit has been merged into the sched/core branch of tip:

Commit-ID: f912d051619d11411867f642d2004928eb0b41b1
Gitweb: https://git.kernel.org/tip/f912d051619d11411867f642d2004928eb0b41b1
Author: Wang Hui <[email protected]>
AuthorDate: Wed, 21 Jul 2021 17:11:09 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Wed, 04 Aug 2021 15:16:43 +02:00

sched: remove redundant on_rq status change

activate_task/deactivate_task will change on_rq status,
no need to do it again.

Signed-off-by: Wang Hui <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0c22cd0..6c562ad 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5659,11 +5659,9 @@ static bool try_steal_cookie(int this, int that)
if (p->core_occupation > dst->idle->core_occupation)
goto next;

- p->on_rq = TASK_ON_RQ_MIGRATING;
deactivate_task(src, p, 0);
set_task_cpu(p, this);
activate_task(dst, p, 0);
- p->on_rq = TASK_ON_RQ_QUEUED;

resched_curr(dst);