2021-07-21 21:44:19

by Sonia Sharma

Subject: [PATCH] hv: Remove unused inline functions in hyperv.h

From: Sonia Sharma <[email protected]>

There are some unused inline functions in hyperv header file.
Remove those unused functions.

Signed-off-by: Sonia Sharma <[email protected]>
---
include/linux/hyperv.h | 16 ----------------
1 file changed, 16 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 2e859d2..ddc8713 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -538,12 +538,6 @@ struct vmbus_channel_rescind_offer {
u32 child_relid;
} __packed;

-static inline u32
-hv_ringbuffer_pending_size(const struct hv_ring_buffer_info *rbi)
-{
- return rbi->ring_buffer->pending_send_sz;
-}
-
/*
* Request Offer -- no parameters, SynIC message contains the partition ID
* Set Snoop -- no parameters, SynIC message contains the partition ID
@@ -1092,16 +1086,6 @@ static inline void set_channel_pending_send_size(struct vmbus_channel *c,
c->outbound.ring_buffer->pending_send_sz = size;
}

-static inline void set_low_latency_mode(struct vmbus_channel *c)
-{
- c->low_latency = true;
-}
-
-static inline void clear_low_latency_mode(struct vmbus_channel *c)
-{
- c->low_latency = false;
-}
-
void vmbus_onmessage(struct vmbus_channel_message_header *hdr);

int vmbus_request_offers(void);
--
1.8.3.1

2021-07-22 05:40:14

by Michael Kelley (LINUX)

Subject: RE: [PATCH] hv: Remove unused inline functions in hyperv.h

From: Sonia Sharma <[email protected]> Sent: Wednesday, July 21, 2021 2:41 PM
>
> There are some unused inline functions in hyperv header file.
> Remove those unused functions.
>
> Signed-off-by: Sonia Sharma <[email protected]>
> ---
> include/linux/hyperv.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 2e859d2..ddc8713 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -538,12 +538,6 @@ struct vmbus_channel_rescind_offer {
> u32 child_relid;
> } __packed;
>
> -static inline u32
> -hv_ringbuffer_pending_size(const struct hv_ring_buffer_info *rbi)
> -{
> - return rbi->ring_buffer->pending_send_sz;
> -}
> -
> /*
> * Request Offer -- no parameters, SynIC message contains the partition ID
> * Set Snoop -- no parameters, SynIC message contains the partition ID
> @@ -1092,16 +1086,6 @@ static inline void set_channel_pending_send_size(struct vmbus_channel *c,
> c->outbound.ring_buffer->pending_send_sz = size;
> }
>
> -static inline void set_low_latency_mode(struct vmbus_channel *c)
> -{
> - c->low_latency = true;
> -}
> -
> -static inline void clear_low_latency_mode(struct vmbus_channel *c)
> -{
> - c->low_latency = false;
> -}
> -
> void vmbus_onmessage(struct vmbus_channel_message_header *hdr);
>
> int vmbus_request_offers(void);
> --
> 1.8.3.1

Reviewed-by: Michael Kelley <[email protected]>

2021-07-22 10:19:18

by Wei Liu

Subject: Re: [PATCH] hv: Remove unused inline functions in hyperv.h

On Thu, Jul 22, 2021 at 05:35:31AM +0000, Michael Kelley wrote:
> From: Sonia Sharma <[email protected]> Sent: Wednesday, July 21, 2021 2:41 PM
> >
> > There are some unused inline functions in hyperv header file.
> > Remove those unused functions.
> >
> > Signed-off-by: Sonia Sharma <[email protected]>
>
> Reviewed-by: Michael Kelley <[email protected]>
>

Applied to hyperv-next with minor adjustments to commit message.

Wei.