2021-07-24 20:00:35

by Salah Triki

Subject: [PATCH] usb: stkwebcam: update the reference count of the usb device structure

Use usb_get_dev() and usb_put_dev() in order to update the reference
count of the usb device structure.

Signed-off-by: Salah Triki <[email protected]>
---
drivers/media/usb/stkwebcam/stk-webcam.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
index a45d464427c4..3b14679829ed 100644
--- a/drivers/media/usb/stkwebcam/stk-webcam.c
+++ b/drivers/media/usb/stkwebcam/stk-webcam.c
@@ -1309,7 +1309,7 @@ static int stk_camera_probe(struct usb_interface *interface,
init_waitqueue_head(&dev->wait_frame);
dev->first_init = 1; /* webcam LED management */

- dev->udev = udev;
+ dev->udev = usb_get_dev(udev);
dev->interface = interface;
usb_get_intf(interface);

@@ -1376,6 +1376,7 @@ static void stk_camera_disconnect(struct usb_interface *interface)

usb_set_intfdata(interface, NULL);
unset_present(dev);
+ usb_put_dev(interface_to_usbdev(interface));

wake_up_interruptible(&dev->wait_frame);

--
2.25.1

2021-07-25 06:42:10

by Greg KH

Subject: Re: [PATCH] usb: stkwebcam: update the reference count of the usb device structure

On Sat, Jul 24, 2021 at 08:58:31PM +0100, Salah Triki wrote:
> Use usb_get_dev() and usb_put_dev() in order to update the reference
> count of the usb device structure.

Why?