2021-07-25 18:03:05

by Harshvardhan Jha

Subject: [PATCH net] net: qede: Fix end of loop tests for list_for_each_entry

The list_for_each_entry() iterator, "vlan" in this code, can never be
NULL so the warning will never be printed.

Signed-off-by: Harshvardhan Jha <[email protected]>
---
From static analysis. Not tested.
---
drivers/net/ethernet/qlogic/qede/qede_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index c59b72c90293..a2e4dfb5cb44 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -831,7 +831,7 @@ int qede_configure_vlan_filters(struct qede_dev *edev)
int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
{
struct qede_dev *edev = netdev_priv(dev);
- struct qede_vlan *vlan = NULL;
+ struct qede_vlan *vlan;
int rc = 0;

DP_VERBOSE(edev, NETIF_MSG_IFDOWN, "Removing vlan 0x%04x\n", vid);
@@ -842,7 +842,7 @@ int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
if (vlan->vid == vid)
break;

- if (!vlan || (vlan->vid != vid)) {
+ if (list_entry_is_head(vlan, &edev->vlan_list, list)) {
DP_VERBOSE(edev, (NETIF_MSG_IFUP | NETIF_MSG_IFDOWN),
"Vlan isn't configured\n");
goto out;
--
2.32.0

2021-07-25 22:11:13

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: qede: Fix end of loop tests for list_for_each_entry

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 25 Jul 2021 23:28:04 +0530 you wrote:
> The list_for_each_entry() iterator, "vlan" in this code, can never be
> NULL so the warning will never be printed.
>
> Signed-off-by: Harshvardhan Jha <[email protected]>
> ---
> From static analysis. Not tested.
>
> [...]

Here is the summary with links:
- [net] net: qede: Fix end of loop tests for list_for_each_entry
https://git.kernel.org/netdev/net/c/795e3d2ea68e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html