2021-07-26 11:53:45

by Manyi Li

[permalink] [raw]
Subject: [PATCH] scsi: sr: Return correct event when media event code is 3

the description for media event code 0: NoChg
Media status is unchanged.

the description for media event code 1: EjectRequest
The Drive has received a request from the user (usually through a
mechanical switch on the Drive) to eject the specified slot or media.

the description for media event code 2: NewMedia
The specified slot (or the Drive) has received new media, and is
ready to access it.

the description for media event code 3: MediaRemoval
The media has been removed from the specified slot, and the
Drive is unable to access the media without user intervention.
This applies to media changers only.

fix bug: https://bugzilla.kernel.org/show_bug.cgi?id=213759

Signed-off-by: Li Manyi <[email protected]>
---
drivers/scsi/sr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 94c254e9012e..a6d3ac0a6cbc 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -221,7 +221,7 @@ static unsigned int sr_get_events(struct scsi_device *sdev)
else if (med->media_event_code == 2)
return DISK_EVENT_MEDIA_CHANGE;
else if (med->media_event_code == 3)
- return DISK_EVENT_EJECT_REQUEST;
+ return DISK_EVENT_MEDIA_CHANGE;
return 0;
}

--
2.20.1




2021-07-29 03:39:19

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: sr: Return correct event when media event code is 3

On Mon, 26 Jul 2021 19:49:13 +0800, Li Manyi wrote:

> the description for media event code 0: NoChg
> Media status is unchanged.
>
> the description for media event code 1: EjectRequest
> The Drive has received a request from the user (usually through a
> mechanical switch on the Drive) to eject the specified slot or media.
>
> [...]

Applied to 5.14/scsi-fixes, thanks!

[1/1] scsi: sr: Return correct event when media event code is 3
https://git.kernel.org/mkp/scsi/c/eea4d790a8d7

--
Martin K. Petersen Oracle Linux Engineering