2021-07-20 04:39:00

by Sibi Sankar

[permalink] [raw]
Subject: [PATCH v4 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain

The power-domains exposed by AOSS QMP node are used to notify the Always
on Subsystem (AOSS) that a particular co-processor is up/down. These
co-processors enter low-power modes independent to that of the application
processor and their states are expected to remain unaltered across system
suspend/resume cycles. To achieve this behavior let's drop the load
power-domain and replace them with generic qmp_send interface instead.

Signed-off-by: Sibi Sankar <[email protected]>
---

v4:
* Rebase patch due to the recent aoss-qmp yaml conversion (Dropping Rb).

Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
index 93e4b737ee1b..c55e98fc14fa 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
@@ -19,8 +19,7 @@ description:

The AOSS side channel exposes control over a set of resources, used to control
a set of debug related clocks and to affect the low power state of resources
- related to the secondary subsystems. These resources are exposed as a set of
- power-domains.
+ related to the secondary subsystems.

properties:
compatible:
@@ -57,13 +56,6 @@ properties:
description:
The single clock represents the QDSS clock.

- "#power-domain-cells":
- const: 1
- description: |
- The provided power-domains are:
- CDSP state (0), LPASS state (1), modem state (2), SLPI
- state (3), SPSS state (4) and Venus state (5).
-
required:
- compatible
- reg
@@ -101,7 +93,6 @@ examples:
mboxes = <&apss_shared 0>;

#clock-cells = <0>;
- #power-domain-cells = <1>;

cx_cdev: cx {
#cooling-cells = <2>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2021-07-20 21:16:26

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [PATCH v4 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain

On Tue, Jul 20, 2021 at 10:06:35AM +0530, Sibi Sankar wrote:
> The power-domains exposed by AOSS QMP node are used to notify the Always
> on Subsystem (AOSS) that a particular co-processor is up/down. These
> co-processors enter low-power modes independent to that of the application
> processor and their states are expected to remain unaltered across system
> suspend/resume cycles. To achieve this behavior let's drop the load
> power-domain and replace them with generic qmp_send interface instead.
>
> Signed-off-by: Sibi Sankar <[email protected]>

Reviewed-by: Matthias Kaehlcke <[email protected]>

2021-07-21 05:34:17

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v4 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain

Quoting Sibi Sankar (2021-07-19 21:36:35)
> The power-domains exposed by AOSS QMP node are used to notify the Always
> on Subsystem (AOSS) that a particular co-processor is up/down. These
> co-processors enter low-power modes independent to that of the application
> processor and their states are expected to remain unaltered across system
> suspend/resume cycles. To achieve this behavior let's drop the load
> power-domain and replace them with generic qmp_send interface instead.
>
> Signed-off-by: Sibi Sankar <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-07-26 22:39:25

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain

On Tue, 20 Jul 2021 10:06:35 +0530, Sibi Sankar wrote:
> The power-domains exposed by AOSS QMP node are used to notify the Always
> on Subsystem (AOSS) that a particular co-processor is up/down. These
> co-processors enter low-power modes independent to that of the application
> processor and their states are expected to remain unaltered across system
> suspend/resume cycles. To achieve this behavior let's drop the load
> power-domain and replace them with generic qmp_send interface instead.
>
> Signed-off-by: Sibi Sankar <[email protected]>
> ---
>
> v4:
> * Rebase patch due to the recent aoss-qmp yaml conversion (Dropping Rb).
>
> Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>

Acked-by: Rob Herring <[email protected]>