2021-07-27 05:23:22

by Cai,Huoqing

Subject: [PATCH] drm/pl111: Remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/gpu/drm/pl111/pl111_display.c | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
index b5a8859739a2..443e3b932322 100644
--- a/drivers/gpu/drm/pl111/pl111_display.c
+++ b/drivers/gpu/drm/pl111/pl111_display.c
@@ -11,7 +11,6 @@

#include <linux/clk.h>
#include <linux/delay.h>
-#include <linux/version.h>
#include <linux/dma-buf.h>
#include <linux/of_graph.h>

diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index fa0a737e9dea..520301b405f1 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -44,7 +44,6 @@
#include <linux/of_reserved_mem.h>
#include <linux/shmem_fs.h>
#include <linux/slab.h>
-#include <linux/version.h>

#include <drm/drm_atomic_helper.h>
#include <drm/drm_bridge.h>
--
2.25.1

2021-07-27 14:32:11

by Randy Dunlap

Subject: Re: [PATCH] drm/pl111: Remove unused including <linux/version.h>

On 7/26/21 10:21 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

as reported by 'make versioncheck':

../drivers/gpu/drm/pl111/pl111_display.c: 14 linux/version.h not needed.
../drivers/gpu/drm/pl111/pl111_drv.c: 47 linux/version.h not needed.


> ---
> drivers/gpu/drm/pl111/pl111_display.c | 1 -
> drivers/gpu/drm/pl111/pl111_drv.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b5a8859739a2..443e3b932322 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -11,7 +11,6 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
> -#include <linux/version.h>
> #include <linux/dma-buf.h>
> #include <linux/of_graph.h>
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index fa0a737e9dea..520301b405f1 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -44,7 +44,6 @@
> #include <linux/of_reserved_mem.h>
> #include <linux/shmem_fs.h>
> #include <linux/slab.h>
> -#include <linux/version.h>
>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_bridge.h>
>

thanks.
--
~Randy