2021-07-27 05:43:47

by Cai,Huoqing

Subject: [PATCH] soc/tegra: bpmp: Remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/media/usb/uvc/uvc_driver.c | 1 -
drivers/soc/tegra/powergate-bpmp.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 9a791d8ef200..b1b055784f8d 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -16,7 +16,6 @@
#include <linux/videodev2.h>
#include <linux/vmalloc.h>
#include <linux/wait.h>
-#include <linux/version.h>
#include <asm/unaligned.h>

#include <media/v4l2-common.h>
diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
index 06c792bafca5..8eaf50d0b6af 100644
--- a/drivers/soc/tegra/powergate-bpmp.c
+++ b/drivers/soc/tegra/powergate-bpmp.c
@@ -7,7 +7,6 @@
#include <linux/platform_device.h>
#include <linux/pm_domain.h>
#include <linux/slab.h>
-#include <linux/version.h>

#include <soc/tegra/bpmp.h>
#include <soc/tegra/bpmp-abi.h>
--
2.25.1

2021-07-27 08:59:29

by Laurent Pinchart

Subject: Re: [PATCH] soc/tegra: bpmp: Remove unused including <linux/version.h>

Hi Cai,

Thank you for the patch.

On Tue, Jul 27, 2021 at 01:42:28PM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 1 -

For the uvcvideo driver,

Reviewed-by: Laurent Pinchart <[email protected]>

As this patch combines changes to two different subsystems, should I
assume you'll get it merged as a tree-wide change and that I can forget
about it ? If that's not right, then it may be best to split the patch
in two.

> drivers/soc/tegra/powergate-bpmp.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
> #include <linux/videodev2.h>
> #include <linux/vmalloc.h>
> #include <linux/wait.h>
> -#include <linux/version.h>
> #include <asm/unaligned.h>
>
> #include <media/v4l2-common.h>
> diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
> index 06c792bafca5..8eaf50d0b6af 100644
> --- a/drivers/soc/tegra/powergate-bpmp.c
> +++ b/drivers/soc/tegra/powergate-bpmp.c
> @@ -7,7 +7,6 @@
> #include <linux/platform_device.h>
> #include <linux/pm_domain.h>
> #include <linux/slab.h>
> -#include <linux/version.h>
>
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>

--
Regards,

Laurent Pinchart