2021-07-27 09:31:16

by Cai,Huoqing

Subject: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

V1->V2: Split the patch in two.

Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/media/usb/uvc/uvc_driver.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 9a791d8ef200..b1b055784f8d 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -16,7 +16,6 @@
#include <linux/videodev2.h>
#include <linux/vmalloc.h>
#include <linux/wait.h>
-#include <linux/version.h>
#include <asm/unaligned.h>

#include <media/v4l2-common.h>
--
2.25.1

2021-07-27 09:32:37

by Cai,Huoqing

Subject: [PATCH V2] soc/tegra: bpmp: Remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

V1->V2: Split the patch in two

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/soc/tegra/powergate-bpmp.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
index 06c792bafca5..8eaf50d0b6af 100644
--- a/drivers/soc/tegra/powergate-bpmp.c
+++ b/drivers/soc/tegra/powergate-bpmp.c
@@ -7,7 +7,6 @@
#include <linux/platform_device.h>
#include <linux/pm_domain.h>
#include <linux/slab.h>
-#include <linux/version.h>

#include <soc/tegra/bpmp.h>
#include <soc/tegra/bpmp-abi.h>
--
2.25.1

2021-07-27 20:50:41

by Randy Dunlap

Subject: Re: [PATCH V2] soc/tegra: bpmp: Remove unused including <linux/version.h>

On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> V1->V2: Split the patch in two
>
> Signed-off-by: Cai Huoqing <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

as reported by 'make versioncheck':

../drivers/soc/tegra/powergate-bpmp.c: 10 linux/version.h not needed.

thanks.

> ---
> drivers/soc/tegra/powergate-bpmp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
> index 06c792bafca5..8eaf50d0b6af 100644
> --- a/drivers/soc/tegra/powergate-bpmp.c
> +++ b/drivers/soc/tegra/powergate-bpmp.c
> @@ -7,7 +7,6 @@
> #include <linux/platform_device.h>
> #include <linux/pm_domain.h>
> #include <linux/slab.h>
> -#include <linux/version.h>
>
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>
>


--
~Randy

2021-07-27 20:52:07

by Randy Dunlap

Subject: Re: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>

On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> V1->V2: Split the patch in two.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Cai Huoqing <[email protected]>

as reported by 'make versioncheck':

../drivers/media/usb/uvc/uvc_driver.c: 19 linux/version.h not needed.

Acked-by: Randy Dunlap <[email protected]>

thanks.

> ---
> drivers/media/usb/uvc/uvc_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
> #include <linux/videodev2.h>
> #include <linux/vmalloc.h>
> #include <linux/wait.h>
> -#include <linux/version.h>
> #include <asm/unaligned.h>
>
> #include <media/v4l2-common.h>
>


--
~Randy

2021-07-28 05:46:35

by Laurent Pinchart

Subject: Re: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>

Hi Cai,

Thank you for the patch.

On Tue, Jul 27, 2021 at 05:28:53PM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> V1->V2: Split the patch in two.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Cai Huoqing <[email protected]>

Taken in my tree for v5.15. Thank you.

> ---
> drivers/media/usb/uvc/uvc_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
> #include <linux/videodev2.h>
> #include <linux/vmalloc.h>
> #include <linux/wait.h>
> -#include <linux/version.h>
> #include <asm/unaligned.h>
>
> #include <media/v4l2-common.h>

--
Regards,

Laurent Pinchart