2021-07-31 04:54:01

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH] dt-bindings: net: can: Document power-domains property

Document power-domains property for adding the Power domain provider.

Signed-off-by: Aswath Govindraju <[email protected]>
---
Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index a7b5807c5543..d633fe1da870 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -104,6 +104,13 @@ properties:
maximum: 32
maxItems: 1

+ power-domains:
+ description:
+ Power domain provider node and an args specifier containing
+ the can device id value. Please see,
+ Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
+ maxItems: 1
+
can-transceiver:
$ref: can-transceiver.yaml#

--
2.17.1



2021-08-02 07:12:23

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: can: Document power-domains property

On 31.07.2021 10:21:38, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
> maximum: 32
> maxItems: 1
>
> + power-domains:
> + description:
> + Power domain provider node and an args specifier containing
> + the can device id value. Please see,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml

Why are you referring to a TI specific file in a generic binding?

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachments:
(No filename) (1.26 kB)
 signature.asc (499.00 B)
 Download all attachments

2021-08-02 08:33:45

by Aswath Govindraju

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: can: Document power-domains property

Hi Marc,

On 02/08/21 12:40 pm, Marc Kleine-Budde wrote:
> On 31.07.2021 10:21:38, Aswath Govindraju wrote:
>> Document power-domains property for adding the Power domain provider.
>>
>> Signed-off-by: Aswath Govindraju <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> index a7b5807c5543..d633fe1da870 100644
>> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> @@ -104,6 +104,13 @@ properties:
>> maximum: 32
>> maxItems: 1
>>
>> + power-domains:
>> + description:
>> + Power domain provider node and an args specifier containing
>> + the can device id value. Please see,
>> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
>
> Why are you referring to a TI specific file in a generic binding?
>

I was trying to refer to an example. If it shouldn't be referred then I
will remove it an post a post a respin.

Thanks,
Aswath

> Marc
>


2021-08-02 09:23:37

by Aswath Govindraju

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: can: Document power-domains property

Hi all,

On 31/07/21 10:21 am, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---

Posted respin v2[1] for this patch, after removing the reference in
description.

[1] - https://lore.kernel.org/patchwork/patch/1470806/

Thanks,
Aswath

> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
> maximum: 32
> maxItems: 1
>
> + power-domains:
> + description:
> + Power domain provider node and an args specifier containing
> + the can device id value. Please see,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> + maxItems: 1
> +
> can-transceiver:
> $ref: can-transceiver.yaml#
>
>