2021-08-02 12:11:26

by Tang Bin

Subject: [PATCH v2] iio: adc: fsl-imx25-gcq: fix the right check and simplify code

For the function of platform_get_irq(), the example in platform.c is
* int irq = platform_get_irq(pdev, 0);
* if (irq < 0)
* return irq;
the return value of zero is unnecessary to check, so make the right
check and simplify code.

Co-developed-by: Zhang Shengju <[email protected]>
Signed-off-by: Zhang Shengju <[email protected]>
Signed-off-by: Tang Bin <[email protected]>
---
Changes from v1
- change the code to the original place and make it simple.
- change the commit message.
---
drivers/iio/adc/fsl-imx25-gcq.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index 8cb51cf7a..2cdf45aa8 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -336,14 +336,11 @@ static int mx25_gcq_probe(struct platform_device *pdev)
goto err_vref_disable;
}

- priv->irq = platform_get_irq(pdev, 0);
- if (priv->irq <= 0) {
- ret = priv->irq;
- if (!ret)
- ret = -ENXIO;
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
goto err_clk_unprepare;
- }

+ priv->irq = ret;
ret = request_irq(priv->irq, mx25_gcq_irq, 0, pdev->name, priv);
if (ret) {
dev_err(dev, "Failed requesting IRQ\n");
--
2.20.1.windows.1

2021-08-08 13:53:50

by Jonathan Cameron

Subject: Re: [PATCH v2] iio: adc: fsl-imx25-gcq: fix the right check and simplify code

On Mon, 2 Aug 2021 20:09:29 +0800
Tang Bin <[email protected]> wrote:

> For the function of platform_get_irq(), the example in platform.c is
> * int irq = platform_get_irq(pdev, 0);
> * if (irq < 0)
> * return irq;
> the return value of zero is unnecessary to check, so make the right
> check and simplify code.
>
> Co-developed-by: Zhang Shengju <[email protected]>
> Signed-off-by: Zhang Shengju <[email protected]>
> Signed-off-by: Tang Bin <[email protected]>

Applied. I tweaked the message an title to make it clear this isn't
a fix, but rather a little clean up with no functional affect.

Thanks,

Jonathan

> ---
> Changes from v1
> - change the code to the original place and make it simple.
> - change the commit message.
> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index 8cb51cf7a..2cdf45aa8 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -336,14 +336,11 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> goto err_vref_disable;
> }
>
> - priv->irq = platform_get_irq(pdev, 0);
> - if (priv->irq <= 0) {
> - ret = priv->irq;
> - if (!ret)
> - ret = -ENXIO;
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> goto err_clk_unprepare;
> - }
>
> + priv->irq = ret;
> ret = request_irq(priv->irq, mx25_gcq_irq, 0, pdev->name, priv);
> if (ret) {
> dev_err(dev, "Failed requesting IRQ\n");