2021-08-03 10:18:54

by Ohhoon Kwon

Subject: [PATCH] of: fdt: do not update local variable after use

Fix the below warning:
drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
[clang-analyzer-deadcode.DeadStores]
pprev = &pp->next;
^ ~~~~~~~~~

Signed-off-by: Ohhoon Kwon <[email protected]>
---
drivers/of/fdt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index bd35ba56aa96..5dc0b0310d7c 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -193,7 +193,6 @@ static void populate_properties(const void *blob,
pp->length = len;
pp->value = pp + 1;
*pprev = pp;
- pprev = &pp->next;
memcpy(pp->value, ps, len - 1);
((char *)pp->value)[len - 1] = 0;
pr_debug("fixed up name for %s -> %s\n",
--
2.32.0

2021-08-03 22:21:56

by Rob Herring

Subject: Re: [PATCH] of: fdt: do not update local variable after use

On Tue, 03 Aug 2021 19:13:09 +0900, Ohhoon Kwon wrote:
> Fix the below warning:
> drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
> [clang-analyzer-deadcode.DeadStores]
> pprev = &pp->next;
> ^ ~~~~~~~~~
>
> Signed-off-by: Ohhoon Kwon <[email protected]>
> ---
> drivers/of/fdt.c | 1 -
> 1 file changed, 1 deletion(-)
>

Applied, thanks!