2021-08-05 05:18:39

by Oleksij Rempel

Subject: [PATCH v1 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

From: Søren Andersen <[email protected]>

Add support for the LOGIC Technologies, Inc LTTD800480070-L6WH-RT

Co-Developed-by: Søren Andersen <[email protected]>
Co-Developed-by: Sam Ravnborg <[email protected]>
Signed-off-by: Søren Andersen <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index fda79a986d12..e5213a610ae9 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2967,6 +2967,37 @@ static const struct panel_desc logictechno_lt170410_2whc = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};

+static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = {
+ .clock = 33000,
+ .hdisplay = 800,
+ .hsync_start = 800 + 154,
+ .hsync_end = 800 + 154 + 3,
+ .htotal = 800 + 154 + 3 + 43,
+ .vdisplay = 480,
+ .vsync_start = 480 + 47,
+ .vsync_end = 480 + 47 + 3,
+ .vtotal = 480 + 47 + 3 + 20,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc logictechno_lttd800480070_l6wh_rt = {
+ .modes = &logictechno_lttd800480070_l6wh_rt_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .delay = {
+ .prepare = 45,
+ .enable = 100,
+ .disable = 100,
+ .unprepare = 45
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+};
+
static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
.clock = 30400,
.hdisplay = 800,
@@ -4492,6 +4523,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "logictechno,lt170410-2whc",
.data = &logictechno_lt170410_2whc,
+ }, {
+ .compatible = "logictechno,lttd800480070-l6wh-rt",
+ .data = &logictechno_lttd800480070_l6wh_rt,
}, {
.compatible = "mitsubishi,aa070mc01-ca1",
.data = &mitsubishi_aa070mc01,
--
2.30.2

2021-08-05 05:47:22

by Ahmad Fatoum

Subject: Re: [PATCH v1 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

Hello Oleksi,

On 05.08.21 06:37, Oleksij Rempel wrote:
> From: Søren Andersen <[email protected]>
>
> Add support for the LOGIC Technologies, Inc LTTD800480070-L6WH-RT
>
> Co-Developed-by: Søren Andersen <[email protected]>
> Co-Developed-by: Sam Ravnborg <[email protected]>
> Signed-off-by: Søren Andersen <[email protected]>
> Signed-off-by: Sam Ravnborg <[email protected]>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index fda79a986d12..e5213a610ae9 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2967,6 +2967,37 @@ static const struct panel_desc logictechno_lt170410_2whc = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = {
> + .clock = 33000,
> + .hdisplay = 800,
> + .hsync_start = 800 + 154,
> + .hsync_end = 800 + 154 + 3,
> + .htotal = 800 + 154 + 3 + 43,
> + .vdisplay = 480,
> + .vsync_start = 480 + 47,
> + .vsync_end = 480 + 47 + 3,
> + .vtotal = 480 + 47 + 3 + 20,
> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc logictechno_lttd800480070_l6wh_rt = {
> + .modes = &logictechno_lttd800480070_l6wh_rt_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .delay = {
> + .prepare = 45,
> + .enable = 100,
> + .disable = 100,
> + .unprepare = 45
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

This lacks a .connector_type. I think recent kernels warn about that?

Cheers,
Ahmad

> +};
> +
> static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> .clock = 30400,
> .hdisplay = 800,
> @@ -4492,6 +4523,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "logictechno,lt170410-2whc",
> .data = &logictechno_lt170410_2whc,
> + }, {
> + .compatible = "logictechno,lttd800480070-l6wh-rt",
> + .data = &logictechno_lttd800480070_l6wh_rt,
> }, {
> .compatible = "mitsubishi,aa070mc01-ca1",
> .data = &mitsubishi_aa070mc01,
>


--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |