2021-08-05 20:47:44

by Robert Foss

Subject: [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval

The return value of drm_bridge_attach() is ignored during
the it66121_bridge_attach() call, which is incorrect.

Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
Signed-off-by: Robert Foss <[email protected]>
---
drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 7149ed40af83..2f2a09adb4bc 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -536,6 +536,8 @@ static int it66121_bridge_attach(struct drm_bridge *bridge,
return -EINVAL;

ret = drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags);
+ if (ret)
+ return ret;

ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
IT66121_CLK_BANK_PWROFF_RCLK, 0);
--
2.30.2

2021-08-05 21:37:30

by Jernej Škrabec

Subject: Re: [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval

Hi!

Dne četrtek, 05. avgust 2021 ob 20:50:39 CEST je Robert Foss napisal(a):
> The return value of drm_bridge_attach() is ignored during
> the it66121_bridge_attach() call, which is incorrect.
>
> Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
> Signed-off-by: Robert Foss <[email protected]>
> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

2021-08-06 14:11:42

by Robert Foss

Subject: Re: [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval

On Thu, 5 Aug 2021 at 22:37, Jernej Škrabec <[email protected]> wrote:
>
> Hi!
>
> Dne četrtek, 05. avgust 2021 ob 20:50:39 CEST je Robert Foss napisal(a):
> > The return value of drm_bridge_attach() is ignored during
> > the it66121_bridge_attach() call, which is incorrect.
> >
> > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
> > Signed-off-by: Robert Foss <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Acked-by: Jernej Skrabec <[email protected]>
>

Applied to drm-misc-next