2021-08-06 04:36:01

by Daniel Scally

Subject: [PATCH v3 0/2] Check for endpoints in fwnode->secondary more sensibly

Hello all

A while ago I patched fwnode_graph_get_endpoint_by_id() to check for endpoints
against fwnode->secondary if none was found against the primary. It's actually
better to do this in fwnode_graph_get_next_endpoint() instead, since that
function is called by fwnode_graph_get_endpoint_by_id() and also directly called
in a bunch of other places (primarily sensor drivers checking that they have
endpoints connected during probe). This small series just adds the equivalent
functionality to fwnode_graph_get_next_endpoint() and reverts the earlier
commit.

Thanks
Dan


Daniel Scally (2):
device property: Check fwnode->secondary in
fwnode_graph_get_next_endpoint()
Revert "media: device property: Call fwnode_graph_get_endpoint_by_id()
for fwnode->secondary"

drivers/base/property.c | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)

--
2.25.1

2021-08-06 23:47:00

by Rafael J. Wysocki

Subject: Re: [PATCH v3 0/2] Check for endpoints in fwnode->secondary more sensibly

On Fri, Aug 6, 2021 at 12:10 AM Daniel Scally <[email protected]> wrote:
>
> Hello all
>
> A while ago I patched fwnode_graph_get_endpoint_by_id() to check for endpoints
> against fwnode->secondary if none was found against the primary. It's actually
> better to do this in fwnode_graph_get_next_endpoint() instead, since that
> function is called by fwnode_graph_get_endpoint_by_id() and also directly called
> in a bunch of other places (primarily sensor drivers checking that they have
> endpoints connected during probe). This small series just adds the equivalent
> functionality to fwnode_graph_get_next_endpoint() and reverts the earlier
> commit.
>
> Thanks
> Dan
>
>
> Daniel Scally (2):
> device property: Check fwnode->secondary in
> fwnode_graph_get_next_endpoint()
> Revert "media: device property: Call fwnode_graph_get_endpoint_by_id()
> for fwnode->secondary"
>
> drivers/base/property.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)

The series looks good to me, but can you please resend it with a CC to
linux-acpi?

2021-08-07 00:09:39

by Daniel Scally

Subject: Re: [PATCH v3 0/2] Check for endpoints in fwnode->secondary more sensibly

On 06/08/2021 16:29, Rafael J. Wysocki wrote:
> On Fri, Aug 6, 2021 at 12:10 AM Daniel Scally <[email protected]> wrote:
>> Hello all
>>
>> A while ago I patched fwnode_graph_get_endpoint_by_id() to check for endpoints
>> against fwnode->secondary if none was found against the primary. It's actually
>> better to do this in fwnode_graph_get_next_endpoint() instead, since that
>> function is called by fwnode_graph_get_endpoint_by_id() and also directly called
>> in a bunch of other places (primarily sensor drivers checking that they have
>> endpoints connected during probe). This small series just adds the equivalent
>> functionality to fwnode_graph_get_next_endpoint() and reverts the earlier
>> commit.
>>
>> Thanks
>> Dan
>>
>>
>> Daniel Scally (2):
>> device property: Check fwnode->secondary in
>> fwnode_graph_get_next_endpoint()
>> Revert "media: device property: Call fwnode_graph_get_endpoint_by_id()
>> for fwnode->secondary"
>>
>> drivers/base/property.c | 30 +++++++++++++++++++++---------
>> 1 file changed, 21 insertions(+), 9 deletions(-)
> The series looks good to me, but can you please resend it with a CC to
> linux-acpi?


Yeah sure; I'll do that shortly