2021-08-06 15:34:34

by Colin King

[permalink] [raw]
Subject: [PATCH] scsi: snic: Remove redundant assignment to variable ret

From: Colin Ian King <[email protected]>

The variable ret is being initialized with a value that is never read,
the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/snic/snic_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/snic/snic_scsi.c b/drivers/scsi/snic/snic_scsi.c
index 6dd0ff188bb4..92f5b65c2a27 100644
--- a/drivers/scsi/snic/snic_scsi.c
+++ b/drivers/scsi/snic/snic_scsi.c
@@ -2383,7 +2383,7 @@ snic_host_reset(struct scsi_cmnd *sc)
{
struct Scsi_Host *shost = sc->device->host;
u32 start_time = jiffies;
- int ret = FAILED;
+ int ret;

SNIC_SCSI_DBG(shost,
"host reset:sc %p sc_cmd 0x%x req %p tag %d flags 0x%llx\n",
--
2.31.1


2021-08-10 06:28:36

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: snic: Remove redundant assignment to variable ret


Colin,

> The variable ret is being initialized with a value that is never read,
> the assignment is redundant and can be removed.

Applied to 5.15/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-08-17 03:20:43

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: snic: Remove redundant assignment to variable ret

On Fri, 6 Aug 2021 12:23:13 +0100, Colin King wrote:

> From: Colin Ian King <[email protected]>
>
> The variable ret is being initialized with a value that is never read,
> the assignment is redundant and can be removed.
>
>
>
> [...]

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: snic: Remove redundant assignment to variable ret
https://git.kernel.org/mkp/scsi/c/e9b1adb7c5e3

--
Martin K. Petersen Oracle Linux Engineering