2021-08-10 09:08:58

by Yue Hu

Subject: [PATCH] erofs: directly use wrapper erofs_page_is_managed() when shrinking

From: Yue Hu <[email protected]>

We already have the wrapper function to identify managed page.

Signed-off-by: Yue Hu <[email protected]>
---
fs/erofs/zdata.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 78e4b59..a809730 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -310,7 +310,6 @@ int erofs_try_to_free_all_cached_pages(struct erofs_sb_info *sbi,
{
struct z_erofs_pcluster *const pcl =
container_of(grp, struct z_erofs_pcluster, obj);
- struct address_space *const mapping = MNGD_MAPPING(sbi);
int i;

/*
@@ -327,7 +326,7 @@ int erofs_try_to_free_all_cached_pages(struct erofs_sb_info *sbi,
if (!trylock_page(page))
return -EBUSY;

- if (page->mapping != mapping)
+ if (!erofs_page_is_managed(sbi, page))
continue;

/* barrier is implied in the following 'unlock_page' */
--
1.9.1

2021-08-10 09:45:12

by Gao Xiang

Subject: Re: [PATCH] erofs: directly use wrapper erofs_page_is_managed() when shrinking

On Tue, Aug 10, 2021 at 02:54:50PM +0800, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> We already have the wrapper function to identify managed page.
>
> Signed-off-by: Yue Hu <[email protected]>

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

2021-08-10 23:31:50

by Chao Yu

Subject: Re: [PATCH] erofs: directly use wrapper erofs_page_is_managed() when shrinking

On 2021/8/10 14:54, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> We already have the wrapper function to identify managed page.
>
> Signed-off-by: Yue Hu <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,