2021-08-11 04:40:09

by Huilong Deng

Subject: [PATCH] MIPS: generic: Return true/false (not 1/0) from bool functions

./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in
function 'ocelot_detect' with return type bool

Signed-off-by: Huilong Deng <[email protected]>
---
arch/mips/generic/board-ocelot.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/generic/board-ocelot.c b/arch/mips/generic/board-ocelot.c
index c238e95190ac..7115410acb4f 100644
--- a/arch/mips/generic/board-ocelot.c
+++ b/arch/mips/generic/board-ocelot.c
@@ -26,13 +26,13 @@ static __init bool ocelot_detect(void)
tlb_probe_hazard();
idx = read_c0_index();
if (idx < 0)
- return 0;
+ return false;

/* A TLB entry exists, lets assume its usable and check the CHIP ID */
rev = __raw_readl((void __iomem *)DEVCPU_GCB_CHIP_REGS_CHIP_ID);

if ((rev & CHIP_ID_PART_ID) != OCELOT_PART_ID)
- return 0;
+ return false;

/* Copy command line from bootloader early for Initrd detection */
if (fw_arg0 < 10 && (fw_arg1 & 0xFFF00000) == 0x80000000) {
@@ -44,7 +44,7 @@ static __init bool ocelot_detect(void)
strcpy(arcs_cmdline, prom_argv[1]);
}

- return 1;
+ return true;
}

static void __init ocelot_earlyprintk_init(void)
--
2.32.0

2021-08-12 15:15:34

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: generic: Return true/false (not 1/0) from bool functions

On Wed, Aug 11, 2021 at 12:36:15PM +0800, Huilong Deng wrote:
> ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in
> function 'ocelot_detect' with return type bool
>
> Signed-off-by: Huilong Deng <[email protected]>
> ---
> arch/mips/generic/board-ocelot.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]