2021-08-11 12:22:30

by Tang Bin

Subject: [PATCH] mfd: ti_am335x_tscadc: Delete superfluous error message

In the function ti_tscadc_probe(), when get irq failed,
platform_get_irq() logs an error message, so remove
redundant message here.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/mfd/ti_am335x_tscadc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index 0e6e25308..55adc379f 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -175,10 +175,9 @@ static int ti_tscadc_probe(struct platform_device *pdev)
tscadc->dev = &pdev->dev;

err = platform_get_irq(pdev, 0);
- if (err < 0) {
- dev_err(&pdev->dev, "no irq ID is specified.\n");
+ if (err < 0)
goto ret;
- } else
+ else
tscadc->irq = err;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
2.20.1.windows.1

2021-08-16 13:08:21

by Lee Jones

Subject: Re: [PATCH] mfd: ti_am335x_tscadc: Delete superfluous error message

On Wed, 11 Aug 2021, Tang Bin wrote:

> In the function ti_tscadc_probe(), when get irq failed,
> platform_get_irq() logs an error message, so remove
> redundant message here.
>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog