2021-08-11 07:17:37

by Eizan Miyamoto

Subject: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static

This function isn't and doesn't need to be used outside of
mtk_mdp_comp.c

This patch depends on and is a follow-up to
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929

Signed-off-by: Eizan Miyamoto <[email protected]>
---

drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 9527649de98e..2cf8f1864f8c 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -234,7 +234,7 @@ static const struct component_ops mtk_mdp_component_ops = {
.unbind = mtk_mdp_comp_unbind,
};

-int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
+static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
{
struct device_node *larb_node;
struct platform_device *larb_pdev;
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
index e3d6aef52869..aa6442cc8c1d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
@@ -21,8 +21,6 @@ struct mtk_mdp_comp {
struct device *larb_dev;
};

-int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev);
-
int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);

--
2.32.0.605.g8dce9f2422-goog

2021-08-16 04:28:03

by houlong wei

Subject: Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static

On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
> This function isn't and doesn't need to be used outside of
> mtk_mdp_comp.c
>
> This patch depends on and is a follow-up to
>
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
>
> Signed-off-by: Eizan Miyamoto <[email protected]>
> ---

Reviewed-by: Houlong Wei <[email protected]>

> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 9527649de98e..2cf8f1864f8c 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -234,7 +234,7 @@ static const struct component_ops
> mtk_mdp_component_ops = {
> .unbind = mtk_mdp_comp_unbind,
> };
>
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
> device *dev)
> {
> struct device_node *larb_node;
> struct platform_device *larb_pdev;
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index e3d6aef52869..aa6442cc8c1d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
> struct device *larb_dev;
> };
>
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
> *dev);
> -
> int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
> int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>
> --
> 2.32.0.605.g8dce9f2422-goog
>

2022-04-27 09:43:09

by Hans Verkuil

Subject: Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static

Hi all,

Since the patch series this depends on hasn't been accepted (and using
the components framework is highly controversial in the media subsystem
anyway), I'm marking this (just as the patch series itself) as
'Changes Requested' in the media patchwork. If you want to continue
with this, then this patch should be folded into a v8.

Regards,

Hans

On 16/08/2021 06:26, houlong wei wrote:
> On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
>> This function isn't and doesn't need to be used outside of
>> mtk_mdp_comp.c
>>
>> This patch depends on and is a follow-up to
>>
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
>>
>> Signed-off-by: Eizan Miyamoto <[email protected]>
>> ---
>
> Reviewed-by: Houlong Wei <[email protected]>
>
>> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
>> drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
>> 2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> index 9527649de98e..2cf8f1864f8c 100644
>> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> @@ -234,7 +234,7 @@ static const struct component_ops
>> mtk_mdp_component_ops = {
>> .unbind = mtk_mdp_comp_unbind,
>> };
>>
>> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
>> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
>> device *dev)
>> {
>> struct device_node *larb_node;
>> struct platform_device *larb_pdev;
>> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> index e3d6aef52869..aa6442cc8c1d 100644
>> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
>> struct device *larb_dev;
>> };
>>
>> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
>> *dev);
>> -
>> int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
>> int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>>
>> --
>> 2.32.0.605.g8dce9f2422-goog
>>