2021-08-13 06:54:41

by Tao Ren

[permalink] [raw]
Subject: [PATCH] ARM: dts: aspeed: cloudripper: Add comments for "mdio1"

From: Tao Ren <[email protected]>

Add some comments to explain the purpose of "mdio1" controller: it's
connected to the MDC/MDIO interface of the on-board management switch.

Signed-off-by: Tao Ren <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
index 01ec3ce0a29d..9c6271a17ae8 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
@@ -96,6 +96,11 @@
status = "okay";
};

+/*
+ * "mdio1" is connected to the MDC/MDIO interface of the on-board
+ * management switch (whose ports are connected to BMC, Host and front
+ * panel ethernet port).
+ */
&mdio1 {
status = "okay";
};
--
2.17.1


2021-08-17 08:23:25

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: aspeed: cloudripper: Add comments for "mdio1"

On Fri, 13 Aug 2021 at 06:19, <[email protected]> wrote:
>
> From: Tao Ren <[email protected]>
>
> Add some comments to explain the purpose of "mdio1" controller: it's
> connected to the MDC/MDIO interface of the on-board management switch.
>
> Signed-off-by: Tao Ren <[email protected]>

Thanks, applied.

> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
> index 01ec3ce0a29d..9c6271a17ae8 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dts
> @@ -96,6 +96,11 @@
> status = "okay";
> };
>
> +/*
> + * "mdio1" is connected to the MDC/MDIO interface of the on-board
> + * management switch (whose ports are connected to BMC, Host and front
> + * panel ethernet port).
> + */
> &mdio1 {
> status = "okay";
> };
> --
> 2.17.1
>