2021-08-19 12:10:44

by Colin King

Subject: [PATCH] net: ethernet: ti: cpsw: make array stpa static const, makes object smaller

From: Colin Ian King <[email protected]>

Don't populate the array stpa on the stack but instead it
static const. Makes the object code smaller by 81 bytes:

Before:
text data bss dec hex filename
54993 17248 0 72241 11a31 ./drivers/net/ethernet/ti/cpsw_new.o

After:
text data bss dec hex filename
54784 17376 0 72160 119e0 ./drivers/net/ethernet/ti/cpsw_new.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/ti/cpsw_new.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 85d05b9be2b8..534d39f729e2 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -502,7 +502,7 @@ static void cpsw_restore(struct cpsw_priv *priv)

static void cpsw_init_stp_ale_entry(struct cpsw_common *cpsw)
{
- char stpa[] = {0x01, 0x80, 0xc2, 0x0, 0x0, 0x0};
+ static const char stpa[] = {0x01, 0x80, 0xc2, 0x0, 0x0, 0x0};

cpsw_ale_add_mcast(cpsw->ale, stpa,
ALE_PORT_HOST, ALE_SUPER, 0,
--
2.32.0

2021-08-19 12:35:35

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ethernet: ti: cpsw: make array stpa static const, makes object smaller

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 19 Aug 2021 13:04:43 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the array stpa on the stack but instead it
> static const. Makes the object code smaller by 81 bytes:
>
> Before:
> text data bss dec hex filename
> 54993 17248 0 72241 11a31 ./drivers/net/ethernet/ti/cpsw_new.o
>
> [...]

Here is the summary with links:
- net: ethernet: ti: cpsw: make array stpa static const, makes object smaller
https://git.kernel.org/netdev/net-next/c/5c8a2bb48159

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html