2021-08-23 02:11:25

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the net-next tree

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/broadcom/bnx2.c: In function 'bnx2_read_vpd_fw_ver':
drivers/net/ethernet/broadcom/bnx2.c:8055:6: error: implicit declaration of function 'pci_vpd_find_ro_info_keyword'; did you mean 'pci_vpd_find_info_keyword'? [-Werror=implicit-function-declaration]
8055 | j = pci_vpd_find_ro_info_keyword(data, BNX2_VPD_LEN,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pci_vpd_find_info_keyword

Caused by commit

ddc122aac91f ("bnx2: Search VPD with pci_vpd_find_ro_info_keyword()")

I have used the net-next tree from next-20210820 for today.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-23 06:37:13

by Heiner Kallweit

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the net-next tree

On 23.08.2021 04:09, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/net/ethernet/broadcom/bnx2.c: In function 'bnx2_read_vpd_fw_ver':
> drivers/net/ethernet/broadcom/bnx2.c:8055:6: error: implicit declaration of function 'pci_vpd_find_ro_info_keyword'; did you mean 'pci_vpd_find_info_keyword'? [-Werror=implicit-function-declaration]
> 8055 | j = pci_vpd_find_ro_info_keyword(data, BNX2_VPD_LEN,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | pci_vpd_find_info_keyword
>
> Caused by commit
>
> ddc122aac91f ("bnx2: Search VPD with pci_vpd_find_ro_info_keyword()")
>
> I have used the net-next tree from next-20210820 for today.
>
This series was supposed to go through the PCI tree. It builds on recent patches
that are in the PCI tree, but not in linux-next yet.
I mentioned this dependency in the cover letter for the last series, but forgot
it this time. Sorry.

2021-08-23 10:23:17

by David Miller

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the net-next tree

From: Heiner Kallweit <[email protected]>
Date: Mon, 23 Aug 2021 08:34:53 +0200

> On 23.08.2021 04:09, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the net-next tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> drivers/net/ethernet/broadcom/bnx2.c: In function 'bnx2_read_vpd_fw_ver':
>> drivers/net/ethernet/broadcom/bnx2.c:8055:6: error: implicit declaration of function 'pci_vpd_find_ro_info_keyword'; did you mean 'pci_vpd_find_info_keyword'? [-Werror=implicit-function-declaration]
>> 8055 | j = pci_vpd_find_ro_info_keyword(data, BNX2_VPD_LEN,
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> | pci_vpd_find_info_keyword
>>
>> Caused by commit
>>
>> ddc122aac91f ("bnx2: Search VPD with pci_vpd_find_ro_info_keyword()")
>>
>> I have used the net-next tree from next-20210820 for today.
>>
> This series was supposed to go through the PCI tree. It builds on recent patches
> that are in the PCI tree, but not in linux-next yet.
> I mentioned this dependency in the cover letter for the last series, but forgot
> it this time. Sorry.

I reverted it all, please don't forget the cover letter like this.

Thanks.