2021-08-24 10:33:07

by Julian Wiedmann

Subject: [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize()

Use the right macro to get rid of a magic number.

Signed-off-by: Julian Wiedmann <[email protected]>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index f6360490a4a3..fa1043d74e36 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2835,7 +2835,7 @@ void device_initialize(struct device *dev)
spin_lock_init(&dev->devres_lock);
INIT_LIST_HEAD(&dev->devres_head);
device_pm_init(dev);
- set_dev_node(dev, -1);
+ set_dev_node(dev, NUMA_NO_NODE);
#ifdef CONFIG_GENERIC_MSI_IRQ
INIT_LIST_HEAD(&dev->msi_list);
#endif
--
2.25.1

2021-08-24 13:13:00

by Greg Kroah-Hartman

Subject: Re: [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize()

On Tue, Aug 24, 2021 at 12:30:55PM +0200, Julian Wiedmann wrote:
> Use the right macro to get rid of a magic number.

That is a very vague changelog comment. You can do better :)

thanks,

greg k-h