2021-08-19 00:29:02

by Kari Argillander

Subject: [PATCH v2 4/6] fs/ntfs3: Make mount option nohidden more universal

If we call Opt_nohidden with just keyword hidden, then we can use
hidden/nohidden when mounting. We already use this method for almoust
all other parameters so it is just logical that this will use same
method.

Signed-off-by: Kari Argillander <[email protected]>
---
fs/ntfs3/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 39936a4ce831..8e86e1956486 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -256,7 +256,7 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
fsparam_flag_no("discard", Opt_discard),
fsparam_flag_no("force", Opt_force),
fsparam_flag_no("sparse", Opt_sparse),
- fsparam_flag("nohidden", Opt_nohidden),
+ fsparam_flag_no("hidden", Opt_nohidden),
fsparam_flag_no("acl", Opt_acl),
fsparam_flag_no("showmeta", Opt_showmeta),
fsparam_string("nls", Opt_nls),
@@ -317,7 +317,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc,
opts->sparse = result.negated ? 0 : 1;
break;
case Opt_nohidden:
- opts->nohidden = 1;
+ opts->nohidden = result.negated ? 1 : 0;
break;
case Opt_acl:
if (!result.negated)
--
2.25.1

2021-08-24 08:06:15

by Christoph Hellwig

Subject: Re: [PATCH v2 4/6] fs/ntfs3: Make mount option nohidden more universal

On Thu, Aug 19, 2021 at 03:26:31AM +0300, Kari Argillander wrote:
> If we call Opt_nohidden with just keyword hidden, then we can use
> hidden/nohidden when mounting. We already use this method for almoust
> all other parameters so it is just logical that this will use same
> method.
>
> Signed-off-by: Kari Argillander <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2021-08-24 11:18:21

by Christian Brauner

Subject: Re: [PATCH v2 4/6] fs/ntfs3: Make mount option nohidden more universal

On Thu, Aug 19, 2021 at 03:26:31AM +0300, Kari Argillander wrote:
> If we call Opt_nohidden with just keyword hidden, then we can use
> hidden/nohidden when mounting. We already use this method for almoust
> all other parameters so it is just logical that this will use same
> method.
>
> Signed-off-by: Kari Argillander <[email protected]>
> ---

Sounds good. Thanks!
Acked-by: Christian Brauner <[email protected]>